[libvirt] [PATCH v2] vz: allow to start vz driver without host cache info

[Martin Kletzander]

On Tue, Nov 07, 2017 at 12:02:05PM +0300, Mikhail Feoktistov wrote:
>
>On 11.07.2017 15:55, Martin Kletzander wrote:
>> On Tue, Jul 11, 2017 at 03:20:38PM +0300, Mikhail Feoktistov wrote:
>>>
>>> On 11.07.2017 12:22, Martin Kletzander wrote:
>>>> On Tue, Jul 11, 2017 at 04:59:05AM -0400, Mikhail Feoktistov wrote:
>>>>> Show warning message instead of fail operation.
>>>>> It happens if kernel or cpu doesn't support reporting cpu cache info.
>>>>> In case of Virtuozzo file "id" doesn't exist.
>>>>
>>>> What is your kernel version?
>>>>
>>>  3.10.0-514.16.1.vz7.30.10
>>>> Is there another way of getting the information about the cache ID?
>>>> Maybe we need to parse the name of the cache directory 'index2'
>>>> would be
>>>> id 2 maybe?  If there is no other way, then this fix is fine (as most
>>>> drivers do the same thing), but I would rather fix it if that's
>>>> possible.  Unfortunately the cache information is structured stupidly
>>>> compared to other kernel-provided topology-related information.
>>> Only kernel 4.11 reports cache ID (maybe 4.10, but not checked)
>>> 4.9 doesn't report ID
>>
>> Oh, so that is just older kernel.  OK, then.
>>
>> Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
>>
>>> ID doesn't match to indexN
>>>
>>
>> Yeah, in vanilla it is number per level and easily deductible, but not
>> really something we want to add into the code.
>Martin, do you agree with this patch?
>

As I said, if there is no other way, then just not populating the info is
perfectly fine, we don't need to error out.

Have a nice day,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171107/2dcc08a8/attachment-0001.sig>