[libvirt] [PATCH v3 3/5] qemu: Destroy whole memory tree

Michal Privoznik mprivozn at redhat.com
Tue Nov 7 15:51:02 UTC 2017


When removing path where huge pages are call virFileDeleteTree
instead of plain rmdir(). The reason is that in the near future
there's going to be more in the path than just files - some
subdirs. Therefore plain rmdir() is not going to be enough.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index e27cd0d40..8eef2794e 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -3348,7 +3348,7 @@ qemuProcessBuildDestroyMemoryPathsImpl(virQEMUDriverPtr driver,
             return -1;
         }
     } else {
-        if (rmdir(path) < 0 &&
+        if (virFileDeleteTree(path) < 0 &&
             errno != ENOENT)
             VIR_WARN("Unable to remove hugepage path: %s (errno=%d)",
                      path, errno);
-- 
2.13.6




More information about the libvir-list mailing list