[libvirt] [PATCH 4/6] conf: introduce <output> element for <sound> devices

[John Ferlan]

On 11/14/2017 08:45 AM, Pavel Hrdina wrote:
> So far it was not possible to specify how the audio output from guest

s/So far it was/It is/

> should be presented to host/users.  Now it will be possible to do so
> via <output> element for <sound> device where you specify the output
> "type".
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  docs/formatdomain.html.in     |  9 +++++++
>  docs/schemas/domaincommon.rng | 14 ++++++++++
>  src/conf/domain_conf.c        | 61 +++++++++++++++++++++++++++++++++++++++++++
>  src/conf/domain_conf.h        | 14 ++++++++++
>  src/libvirt_private.syms      |  2 ++
>  5 files changed, 100 insertions(+)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 47c43d0666..3b7c367fc7 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -7058,6 +7058,15 @@ qemu-kvm -net nic,model=? /dev/null
>        slot, <a href="#elementsAddress">documented above</a>.
>      </p>
>  
> +    <p>
> +      <span class="since">Since 3.10.0</span> sound device can have

s/sound/, a sound/

> +      an optional <code>output</code> element which configures where
> +      the audio output is connected within host. There is mandatory
> +      <code>type</code> attribute where valid values are 'none' to
> +      disable the audio output, 'spice', 'pa', 'sdl', 'alsa', 'oss'.

I've become preferential to seeing these in a list. I have no idea based
on the text here what 'spice', ... 'oss' really means.  IOW: Why would I
want to set to something else - what does it do/provide?

> +      This might not be supported by all hypervisors.

True, but perhaps also true of many other things, too.

> +    </p>
> +
>      <h4><a id="elementsWatchdog">Watchdog device</a></h4>
>  
>      <p>


Reviewed-by: John Ferlan <jferlan at redhat.com>

John

[...]