[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/12] qemu: Add support for more migration parameters

On 10/26/2017 06:03 PM, Jiri Denemark wrote:
> QEMU is transforming existing special migration parameters (those which
> need dedicated QMP commands to be set or queried) into proper parameters
> handled by query-migrate-parameters and migrate-set-parameters. Even
> though we may still want to use the existing commands adding support for
> tha transformed parameters will help us clean all of them before
> migration and reset them to their original values after a failed
> migration. Thus we wouldn't need to add more ad-hoc code which resets
> some of them and ignores some others.
> Jiri Denemark (12):
>   qemu: Generalize PARSE macro in qemuMonitorJSONGetMigrationParams
>   qemu: Use macro for parsing string migration parameters
>   qemu: Use macro for parsing ull migration parameters
>   qemu: Generalize APPEND macro in qemuMonitorJSONSetMigrationParams
>   qemu: Use macro for setting string migration parameters
>   qemu: Drop giant if statement from qemuMonitorSetMigrationParams
>   qemumonitorjsontest: Rename 1st CHECK macro in migration params test
>   qemumonitorjsontest: Rename 2nd CHECK macro in migration params test
>   qemu: Add support for setting downtime-limit migration parameter
>   qemu: Rename TLS related migration parameters
>   qemu: Add support for max-bandwidth migration parameter
>   qemu: Add support for block-incremental migration parameter
>  src/qemu/qemu_migration.c    |  23 +++++-----
>  src/qemu/qemu_monitor.c      |  20 +++------
>  src/qemu/qemu_monitor.h      |  10 ++++-
>  src/qemu/qemu_monitor_json.c | 104 +++++++++++++++++++++++++++----------------
>  tests/qemumonitorjsontest.c  |  46 ++++++++++++-------
>  5 files changed, 123 insertions(+), 80 deletions(-)

As long as you add an update to docs/news.xml to describe the basics at
least and the addition of parameters for downtime-limit, max-bandwidth,
and block-incremental

Reviewed-by: John Ferlan <jferlan redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]