[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Don't inline virDomainNetTypeSharesHostView



On Thu, Nov 02, 2017 at 09:03:15PM +0100, Jiri Denemark wrote:
When coverage build is enabled, gcc complains about it:

In file included from qemu/qemu_agent.h:29:0,
                from qemu/qemu_driver.c:47:
qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
./conf/domain_conf.h:3397:1: error: inlining failed in call to
'virDomainNetTypeSharesHostView': call is unlikely and code size would
grow [-Werror=inline]
virDomainNetTypeSharesHostView(const virDomainNetDef *net)
^

Signed-off-by: Jiri Denemark <jdenemar redhat com>
---

ACK


Notes:
   Shouldn't we just kill all (or most of) our worthless usage of the
   inline keyword?

shrug


src/conf/domain_conf.c   | 36 ++++++++++++++++++++++++++++++++++++
src/conf/domain_conf.h   | 37 +++----------------------------------
src/libvirt_private.syms |  1 +
3 files changed, 40 insertions(+), 34 deletions(-)

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]