[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [REPOST PATCH v6 0/8] Use secret objects to pass iSCSI passwords



Reposting after 3.9.0 release and refresh to current HEAD. Had to
move the news.xml into the 3.10.0 section as well and address a
couple of merge conflicts.

Original:
https://www.redhat.com/archives/libvir-list/2017-October/msg01012.html

Copy of Original cover letter:

v5: https://www.redhat.com/archives/libvir-list/2017-October/msg00228.html

FWIW: AFAICT this series does not need/require changes that Peter has
      posted for continuing blocked-add saga related to user-specified
      backing chains:

    https://www.redhat.com/archives/libvir-list/2017-October/msg00956.html

Changes since v5:

 * Some patches pushed as part of Peter Krempa's work and the two patches
   to perform the parsing of auth and encryption data in virStorageSource
   were pushed separately

 * Removed patches dealing with qemuDomainStorageSourceCopy and
   virDomainDiskStorageSourceNew

 Patches 9->16 reworked

 Patch1: (previous patch 10)
   - Rework logic to remove the need to pass around the @xmlopt for
     virStorageSourcePtr allocation and instead VIR_ALLOC(iscsisrc->src)
     directly as other consumers do.

 Patch2: (previous patch 11)
   - Use the qemuDomainStorageSourcePrivatePtr and friend macro
     QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE to manage the iscsisrc->src data
     making sure to ensure that srcPriv (e.g. privateData) exists.

 Patch3: (previous patch 12)
   - Only minor merge related changes.

 Patch4: (previous patch 13)
   - Merge related plus additional check to ensure srcPriv exists before
     dereference secinfo

 Patch5: (previous patch 14)
   - No change

 Patch 6: (previous patch 15)
   - Merge related changes, plus checks for srcPriv before deref secinfo

   NB: Testing note - I did ensure at this point if the password secret
       capability check fails that the code will still do the right thing.

 Patch7: (previous patch 9)
   - No change... Presented since it wasn't ACK'd before

 Patch8: (previous patch16)
   - No change
  

John Ferlan (8):
  conf,qemu: Replace iscsisrc fields with virStorageSourcePtr
  qemu: Use private storage source for iscsi instead of private hostdev
  qemu: Remove private hostdev
  qemu: Refactor qemuBuildSCSIiSCSIHostdevDrvStr slightly
  qemu: Get capabilities to use iscsi password-secret argument
  qemu: Use secret objects to pass iSCSI passwords
  docs: Add news article regarding auth/encryption placement
  docs: Add news article to describe iSCSI usage of secret object

 docs/news.xml                                      | 23 ++++++
 src/conf/domain_conf.c                             | 58 ++++++++--------
 src/conf/domain_conf.h                             |  9 +--
 src/lxc/lxc_native.c                               |  2 +-
 src/qemu/qemu_block.c                              | 65 ++++++++++++++++-
 src/qemu/qemu_capabilities.c                       |  2 +
 src/qemu/qemu_capabilities.h                       |  1 +
 src/qemu/qemu_command.c                            | 75 +++++++++++++++-----
 src/qemu/qemu_command.h                            |  3 +-
 src/qemu/qemu_domain.c                             | 81 +++++++---------------
 src/qemu/qemu_domain.h                             | 14 ----
 src/qemu/qemu_hotplug.c                            | 52 +++++++++++++-
 src/qemu/qemu_parse_command.c                      |  4 +-
 src/vbox/vbox_common.c                             |  2 +-
 src/xenconfig/xen_common.c                         |  2 +-
 src/xenconfig/xen_sxpr.c                           |  2 +-
 src/xenconfig/xen_xl.c                             |  2 +-
 tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml    |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |  1 +
 ...xml2argv-disk-drive-network-iscsi-auth-AES.args | 41 +++++++++++
 ...uxml2argv-disk-drive-network-iscsi-auth-AES.xml | 43 ++++++++++++
 ...ml2argv-hostdev-scsi-virtio-iscsi-auth-AES.args | 45 ++++++++++++
 ...xml2argv-hostdev-scsi-virtio-iscsi-auth-AES.xml | 48 +++++++++++++
 tests/qemuxml2argvtest.c                           | 10 +++
 tests/virhostdevtest.c                             |  2 +-
 28 files changed, 451 insertions(+), 140 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-AES.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-AES.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth-AES.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth-AES.xml

-- 
2.13.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]