[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] tests: removing backend xml tag inside some test cases.



On Mon, Oct 16, 2017 at 10:07:57PM -0200, Julio Faracco wrote:
Some test cases have the backend tag inside wrong interfaces. The backend xml
tag does not support <interface type='user|direct|hostdev'>. So this commit
removes some tags inside those interfaces.

Signed-off-by: Julio Faracco <jcfaracco gmail com>
---
tests/qemuxml2argvdata/qemuxml2argv-tap-vhost-incorrect.xml     | 2 --
tests/qemuxml2argvdata/qemuxml2argv-tap-vhost.xml               | 1 -
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml | 2 --
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml           | 1 -
4 files changed, 6 deletions(-)


The point of these tests is to have the behavior of the <backend>
parsing recorded in the test suite.

IIRC these were added before we mocked the tap device creation in
qemuxml2argvtest and we (ab)used the 'user' interface type to test
XML parsing without having any effect on the host system.

The right thing to do here is to change the interface type, not to
delete the backend tag.

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]