[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Don't inline virDomainNetTypeSharesHostView()



On Mon, Nov 06, 2017 at 02:11:30PM +0100, Andrea Bolognani wrote:
Introduced in d86fd2402e9d. Fails to compile on aarch64 with

 qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
 ./conf/domain_conf.h:3406:1: error: inlining failed in call to
   'virDomainNetTypeSharesHostView': call is unlikely and code size
   would grow [-Werror=inline]
  virDomainNetTypeSharesHostView(const virDomainNetDef *net)
  ^
 qemu/qemu_driver.c:11240:66: error: called from here [-Werror=inline]
         !virDomainNetTypeSharesHostView(net)) < 0 ||
                                        ^

Solve the issue by turning it into a regular function.

Signed-off-by: Andrea Bolognani <abologna redhat com>
---
src/conf/domain_conf.c   | 35 +++++++++++++++++++++++++++++++++++
src/conf/domain_conf.h   | 36 ++----------------------------------
src/libvirt_private.syms |  1 +
3 files changed, 38 insertions(+), 34 deletions(-)


NACK, this version disrupts the serenity of whitespace.

https://www.redhat.com/archives/libvir-list/2017-November/msg00076.html

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]