[libvirt] [PATCH] conf: Don't inline virDomainNetTypeSharesHostView()
Ján Tomko
jtomko at redhat.com
Mon Nov 6 13:19:25 UTC 2017
On Mon, Nov 06, 2017 at 02:11:30PM +0100, Andrea Bolognani wrote:
>Introduced in d86fd2402e9d. Fails to compile on aarch64 with
>
> qemu/qemu_driver.c: In function 'qemuDomainSetInterfaceParameters':
> ./conf/domain_conf.h:3406:1: error: inlining failed in call to
> 'virDomainNetTypeSharesHostView': call is unlikely and code size
> would grow [-Werror=inline]
> virDomainNetTypeSharesHostView(const virDomainNetDef *net)
> ^
> qemu/qemu_driver.c:11240:66: error: called from here [-Werror=inline]
> !virDomainNetTypeSharesHostView(net)) < 0 ||
> ^
>
>Solve the issue by turning it into a regular function.
>
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/conf/domain_conf.c | 35 +++++++++++++++++++++++++++++++++++
> src/conf/domain_conf.h | 36 ++----------------------------------
> src/libvirt_private.syms | 1 +
> 3 files changed, 38 insertions(+), 34 deletions(-)
>
NACK, this version disrupts the serenity of whitespace.
https://www.redhat.com/archives/libvir-list/2017-November/msg00076.html
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171106/9dd8097d/attachment-0001.sig>
More information about the libvir-list
mailing list