[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: Properly parse <backingStore/>




On 11/08/2017 09:46 AM, Peter Krempa wrote:
> The terminator would not be parsed properly since the XPath selector was
> looking for an populated element, and also the code did not bother
> assigning the terminating virStorageSourcePtr to the backingStore
> property of the parent.
> 
> Some tests would catch it if there wasn't bigger fallout from the change
> to backing store termination in a693fdba0111. Fix them properly now.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509110
> ---
>  src/conf/domain_conf.c                                     | 14 ++++++--------
>  .../qemuxml2xmlout-disk-active-commit.xml                  |  1 +
>  .../qemuxml2xmlout-disk-backing-chains-active.xml          |  3 +++
>  .../qemuxml2xmlout-disk-mirror-active.xml                  |  4 ++++
>  .../qemuxml2xmloutdata/qemuxml2xmlout-disk-mirror-old.xml  |  4 ++++
>  .../qemuxml2xmlout-seclabel-static-labelskip.xml           |  1 +
>  6 files changed, 19 insertions(+), 8 deletions(-)
> 

FAIL: qemuhotplugtest
44) base-live+disk-scsi-wwn ATTACH disk-scsi-duplicate-wwn            ...
In
'/home/jferlan/git/libvirt.work/tests/qemuhotplugtestdomains/qemuhotplug-base-live+disk-scsi-wwn+disk-scsi-duplicate-wwn.xml':
Offset 693
Expect [t]
Actual [backingStore/>
      <t]

... ^[[31m^[[1mFAILED^[[0m

Once fixed,

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]