[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] numa: avoid failure in nodememstats on non-NUMA systems



On 07.11.2017 21:53, John Ferlan wrote:
[...]
>> +        /* 
>              ^
> A 'git am' told me there was an extra blank space after the * ;-)
> >> +         * Even if built without numactl, libvirt claims
>> +         * to have a one-cells NUMA topology. In such a
>> +         * case return the statistics for the entire host.
>> +         */
>> +        if (!virNumaIsAvailable() && cellNum == 0)
>> +            cellNum = VIR_NODE_MEMORY_STATS_ALL_CELLS;
>> +
> 
> I'm NUMA challenged, but this certainly seems reasonable... and it
> appears you have an ACK from Boris anyway... So I'll give it until
> tomorrow for anyone else to throw up their hands and say this isn't
> right. ;-)... if no one does, then I'll push with the space fix...
thanks for fixing and pushing
[...]

-- 

Mit freundlichen Grüßen/Kind Regards
   Viktor Mihajlovski


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]