[libvirt] [PATCH v6 4/4] xlconfigtest: add tests for numa cell sibling distances

[Jim Fehlig]

On 11/10/2017 01:55 PM, Jim Fehlig wrote:
> On 11/02/2017 09:47 AM, Wim Ten Have wrote:
>> From: Wim ten Have <wim.ten.have at oracle.com>
>>
>> Test a bidirectional xen-xl domxml to and from native for vnuma
>> support administration as brought under this patch series.
>>
>> Added tests for the libxl_domain_config generator determining
>> vnuma conversion for XML-2-json and json-2-XML.
> 
> I think these should be split into two patches. Essentially patch 4 in V5 plus a 
> patch 5 with the new ibxl_domain_config generator test.
> 
>>
>> Signed-off-by: Wim ten Have <wim.ten.have at oracle.com>
>> ---
>> Changes on v5:
>> - Added tests for libxl_domain_config generator.
>> - Introduced empty stubs for xc_physinfo(), xc_sharing_freed_pages(),
>>    xc_sharing_used_frames to satisfy libxl_get_physinfo() under test
>>    simulation for libxlxml2domconfigtest.c
>> ---
>>   tests/libxlxml2domconfigdata/basic-hvm.json        | 95 +++++++++++++++++++++-
>>   tests/libxlxml2domconfigdata/basic-hvm.xml         | 66 ++++++++++++++-
> 
> And instead of adding vNUMA config to the _basic_ test files, 
> vnuma-hvm.{json,xml} seems more appropriate. I've split this out into a patch 5 
> and attached here for completeness.
> 
> IMO this series is ready to go in. I'll wait for your ACK on the doc changes I 
> suggested in patch 1.

Sorry, I meant to say I'll wait for your feedback on my suggested doc changes in 
patch 1 before pushing this series.

Regards,
Jim