[libvirt] [PATCH] Revert "virNetDevSupportBandwidth: Enable QoS for vhostuser"

[Martin Kletzander]

On Fri, Nov 10, 2017 at 04:23:27PM +0100, Michal Privoznik wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1497410
>
>This reverts commit bc8a99ef06417a2303ccab455f9f045e2a617916.
>
>The vhostuser is not a TAP. Therefore our QoS code is not able to
>set any bandwidth. I don't really understand what I was thinking.
>

Yeah, brainfart on both sides, I guess.  I mean the naming can get confusing.
We still give socket to the chardev if I'm not mistaken.  Also didn't you mean
the vhost-net instead, that one is a TUN, right?  But it's not an interface
type, so we don't need to allow it here.

ACK with ears prepared for both of us :(

>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/conf/netdev_bandwidth_conf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/conf/netdev_bandwidth_conf.h b/src/conf/netdev_bandwidth_conf.h
>index c37828065..30f988953 100644
>--- a/src/conf/netdev_bandwidth_conf.h
>+++ b/src/conf/netdev_bandwidth_conf.h
>@@ -46,9 +46,9 @@ static inline bool virNetDevSupportBandwidth(virDomainNetType type)
>     case VIR_DOMAIN_NET_TYPE_NETWORK:
>     case VIR_DOMAIN_NET_TYPE_DIRECT:
>     case VIR_DOMAIN_NET_TYPE_ETHERNET:
>-    case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
>         return true;
>     case VIR_DOMAIN_NET_TYPE_USER:
>+    case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
>     case VIR_DOMAIN_NET_TYPE_SERVER:
>     case VIR_DOMAIN_NET_TYPE_CLIENT:
>     case VIR_DOMAIN_NET_TYPE_MCAST:
>-- 
>2.13.6
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171113/79294901/attachment-0001.sig>