[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/21] caps2xml resctrl-skx-twocaches



Would be nice to have more information here regarding what this is....


On 11/13/2017 03:50 AM, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan redhat com>
> ---
>  .../resctrl/info/L3/cbm_mask                       |  1 +
>  .../resctrl/info/L3/min_cbm_bits                   |  1 +
>  .../resctrl/info/L3/num_closids                    |  1 +
>  .../linux-resctrl-skx-twocaches/resctrl/schemata   |  1 +
>  .../resctrl/some_reservation/schemata              |  1 +
>  .../system/cpu/cpu0/cache/index0/id                |  1 +
>  .../system/cpu/cpu0/cache/index0/level             |  1 +
>  .../system/cpu/cpu0/cache/index0/shared_cpu_list   |  1 +
>  .../system/cpu/cpu0/cache/index0/shared_cpu_map    |  1 +
>  .../system/cpu/cpu0/cache/index0/size              |  1 +
>  .../system/cpu/cpu0/cache/index0/type              |  1 +
>  .../system/cpu/cpu0/cache/index1/id                |  1 +
>  .../system/cpu/cpu0/cache/index1/level             |  1 +
>  .../system/cpu/cpu0/cache/index1/shared_cpu_list   |  1 +
>  .../system/cpu/cpu0/cache/index1/shared_cpu_map    |  1 +
>  .../system/cpu/cpu0/cache/index1/size              |  1 +
>  .../system/cpu/cpu0/cache/index1/type              |  1 +
>  .../system/cpu/cpu0/online                         |  1 +
>  .../system/cpu/cpu0/topology/core_id               |  1 +
>  .../system/cpu/cpu0/topology/core_siblings         |  1 +
>  .../system/cpu/cpu0/topology/core_siblings_list    |  1 +
>  .../system/cpu/cpu0/topology/physical_package_id   |  1 +
>  .../system/cpu/cpu0/topology/thread_siblings       |  1 +
>  .../system/cpu/cpu0/topology/thread_siblings_list  |  1 +
>  .../linux-resctrl-skx-twocaches/system/cpu/online  |  1 +
>  .../linux-resctrl-skx-twocaches/system/cpu/present |  1 +
>  .../system/node/node0/cpu0                         |  1 +
>  .../system/node/node0/cpulist                      |  1 +
>  .../system/node/node0/cpumap                       |  1 +
>  .../system/node/node0/distance                     |  1 +
>  .../linux-resctrl-skx-twocaches/system/node/online |  1 +
>  .../vircaps-x86_64-resctrl-skx-twocaches.xml       | 34 ++++++++++++++++++++++
>  tests/vircaps2xmltest.c                            |  1 +
>  33 files changed, 66 insertions(+)
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/resctrl/info/L3/cbm_mask
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/resctrl/info/L3/min_cbm_bits
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/resctrl/info/L3/num_closids
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/resctrl/schemata
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/resctrl/some_reservation/schemata
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index0/id
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index0/level
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index0/shared_cpu_list
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index0/shared_cpu_map
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index0/size
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index0/type
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index1/id
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index1/level
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index1/shared_cpu_list
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index1/shared_cpu_map
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index1/size
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/cache/index1/type
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/online
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/topology/core_id
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/topology/core_siblings
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/topology/core_siblings_list
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/topology/physical_package_id
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/topology/thread_siblings
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/cpu0/topology/thread_siblings_list
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/online
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/cpu/present
>  create mode 120000 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/node/node0/cpu0
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/node/node0/cpulist
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/node/node0/cpumap
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/node/node0/distance
>  create mode 100644 tests/vircaps2xmldata/linux-resctrl-skx-twocaches/system/node/online
>  create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-resctrl-skx-twocaches.xml
> 

It seems this is just some new test...  It works, but does it add to
test bloat? Could it be merged into existing skx test? IOW: does the
existing test "need" to have just one bank?  I'm OK with the separate
test, but I guess it's just not clear why there needs to be a separate
one (I could have missed something subtle too).  In any case -

Reviewed-by: John Ferlan <jferlan redhat com>

John

[apologies for the "timeliness" of reviews - it's been a distracting
day... Sometimes it's more worthwhile to just turn off IRC ;-)]



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]