[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: fixing wrong datatype of 'set-lifcycle-action' command options.



On 11/16/2017 04:01 AM, Julio Faracco wrote:
> The 'set-lifcycle-action' is throwing a weird error after executing it with
> the '--help' option. The command output is showing the options 'type' and
> 'action' are as optional, but they aren't. Both are required.
> 
> virsh # set-lifecycle-action --help
> ...
>   SYNOPSIS
>     set-lifecycle-action <domain> [--type <string>] [--action <string>] ...
> ...
>   OPTIONS
>     [--domain] <string>  domain name, id or uuid
> error: internal error: bad options in command: 'set-lifecycle-action'
> 
> After applying this patch, both arguments are required now.
> 
> virsh # set-lifecycle-action --help
> ...
>   SYNOPSIS
>     set-lifecycle-action <domain> <type> <action> [--config] ...
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1509870
> 
> Signed-off-by: Julio Faracco <jcfaracco gmail com>
> ---
>  tools/virsh-domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

ACKed and pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]