[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/14] conf, qemu: Use type-aware switches where possible



On Wed, Nov 15, 2017 at 12:50:05PM +0100, Andrea Bolognani wrote:
> The compiler can warn us if we add a value to the
> virDomainChrSerialTargetType enumeration but forget to handle
> it properly in the code. Let's take advantage of that.
> 
> This commit is best viewed with 'git diff -w'.

This sentence should be placed under "---" as a note and not part of
the commit message.

> 
> Signed-off-by: Andrea Bolognani <abologna redhat com>
> ---
>  src/conf/domain_conf.c  | 47 ++++++++++++++++++++++++++++++-----------------
>  src/qemu/qemu_command.c |  7 ++++++-
>  2 files changed, 36 insertions(+), 18 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]