[libvirt] [PATCH 04/14] conf: Run devicePostParse() again for the first serial device
Pavel Hrdina
phrdina at redhat.com
Thu Nov 16 11:06:13 UTC 2017
On Wed, Nov 15, 2017 at 12:50:07PM +0100, Andrea Bolognani wrote:
> The devicePostParse() callback is invoked for all devices so that
> drivers have a chance to set their own specific values; however,
> virDomainDefAddImplicitDevices() runs *after* the devicePostParse()
> callbacks have been invoked and can add new devices, in which case
> the driver wouldn't have a chance to customize them.
>
> Work around the issue by invoking the devicePostParse() callback
> after virDomainDefAddImplicitDevices(), only for the first serial
> devices, which might have been added by it. The same was already
> happening for the first video device for the very same reason.
>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> src/conf/domain_conf.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
So far this was not required but following patches will change how the
"implicit" serial device is added. Might be nice to mention it in the
commit message.
Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171116/c3cc0067/attachment-0001.sig>
More information about the libvir-list
mailing list