[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/14] conf: Run devicePostParse() again for the first serial device



On Wed, Nov 15, 2017 at 12:50:07PM +0100, Andrea Bolognani wrote:
> The devicePostParse() callback is invoked for all devices so that
> drivers have a chance to set their own specific values; however,
> virDomainDefAddImplicitDevices() runs *after* the devicePostParse()
> callbacks have been invoked and can add new devices, in which case
> the driver wouldn't have a chance to customize them.
> 
> Work around the issue by invoking the devicePostParse() callback
> after virDomainDefAddImplicitDevices(), only for the first serial
> devices, which might have been added by it. The same was already
> happening for the first video device for the very same reason.
> 
> Signed-off-by: Andrea Bolognani <abologna redhat com>
> ---
>  src/conf/domain_conf.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)

So far this was not required but following patches will change how the
"implicit" serial device is added.  Might be nice to mention it in the
commit message.

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]