[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/14] qemu: Support usb-serial and pci-serial on pSeries



On Wed, Nov 15, 2017 at 12:50:11PM +0100, Andrea Bolognani wrote:
> The existing implementation set the address type for all serial
> devices to spapr-vio, which made it impossible to use other devices
> such as usb-serial and pci-serial; moreover, some decisions were
> made based on the address type rather than the device type.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1512934
> 
> Signed-off-by: Andrea Bolognani <abologna redhat com>
> ---
>  src/qemu/qemu_command.c                            |  9 -------
>  src/qemu/qemu_domain_address.c                     |  3 ++-
>  .../qemuxml2argv-pseries-serial-pci.args           | 22 ++++++++++++++++
>  .../qemuxml2argv-pseries-serial-pci.xml            | 18 +++++++++++++
>  .../qemuxml2argv-pseries-serial-usb.args           | 23 +++++++++++++++++
>  .../qemuxml2argv-pseries-serial-usb.xml            | 21 +++++++++++++++
>  tests/qemuxml2argvtest.c                           |  7 +++++
>  .../qemuxml2xmlout-pseries-serial-pci.xml          | 29 +++++++++++++++++++++
>  .../qemuxml2xmlout-pseries-serial-usb.xml          | 30 ++++++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  7 +++++
>  10 files changed, 159 insertions(+), 10 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-serial-pci.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-serial-pci.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-serial-usb.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-serial-usb.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-serial-pci.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pseries-serial-usb.xml

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]