[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011



On Wed, Nov 15, 2017 at 12:50:12PM +0100, Andrea Bolognani wrote:
> We can finally introduce a specific target type for the pl011 device
> used by mach-virt guests, which means isa-serial will no longer show
> up to confuse users.
> 
> We make sure migration works in both directions by interpreting the
> isa-serial target type, or the lack of target type, appropriately
> when parsing the guest XML, and skipping the newly-introduced type
> when formatting if for migration. We also verify that pl011 is not
> used for non-mach-virt guests and add a bunch of test cases.

Here the name "pl011" is even worse than "spapr-vty".  It's a device
name and there is also "pl022" (probably not supported by QEMU).  The
bus name is APB (Advanced Peripheral Bus). [1] [2]

How about we introduce another attribute/element that would specify the
exact model of the serial device and it would be optional, libvirt would
be able to choose the model if none is specified.

I was no able to find anything about s390 and its sclp/sclplm consoles
but it's the same case.  I would expect that both devices are connected
to the same BUS, we just need to find the BUS name to use it $BUS-serial
and have sclp/sclplm as models.

Other than the naming the patch looks good.

Pavel

[1] <http://infocenter.arm.com/help/topic/com.arm.doc.ddi0183f/DDI0183.pdf>
[2] <http://infocenter.arm.com/help/topic/com.arm.doc.ddi0194g/DDI0194G_ssp_pl022_r1p3_trm.pdf>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]