[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011



On Thu, Nov 16, 2017 at 03:53:42PM +0100, Andrea Bolognani wrote:
> On Thu, 2017-11-16 at 14:56 +0100, Pavel Hrdina wrote:
> > Here the name "pl011" is even worse than "spapr-vty".  It's a device
> > name and there is also "pl022" (probably not supported by QEMU).  The
> > bus name is APB (Advanced Peripheral Bus). [1] [2]
> 
> QEMU has pl031 and pl061 devices in addition to pl011, but no pl022
> as far as I can tell.
> 
> > How about we introduce another attribute/element that would specify the
> > exact model of the serial device and it would be optional, libvirt would
> > be able to choose the model if none is specified.
> 
> That would have precedents in eg. PCI controllers, where the <model>
> subelement contains the hypervisor-specific device name whereas
> the 'model' attribute of the <controller> element contains a more
> generic name...
> 
> You might have just convinced me :)

good :)

> Of course that would lead to duplicated information in the existing
> cases of ISA, USB and PCI, but I guess we can live with that.

Or the duplication can be solved by documenting, that the model is valid
only for specific types where the model makes sense.

> > I was no able to find anything about s390 and its sclp/sclplm consoles
> > but it's the same case.  I would expect that both devices are connected
> > to the same BUS, we just need to find the BUS name to use it $BUS-serial
> > and have sclp/sclplm as models.
> 
> Pino, any ideas about this?
> 
> -- 
> Andrea Bolognani / Red Hat / Virtualization

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]