[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/3] Fix user provided aliases for some devices



On Wed, Nov 15, 2017 at 03:40:14PM +0100, Michal Privoznik wrote:
In case user provides an alias for a device that is implicit
(e.g. IDE controller for 440fx, SATA for Q35, etc.) we don't put
the device onto qemu command line. Therefore we can't set its
alias.

diff to v1:
- more controllers covered

Michal Privoznik (3):
 virQEMUCapsHasPCIMultiBus: Fix @def type
 qemuBuildDriveDevStr: Prefer default alias for SATA bus
 qemuBuildDeviceAddressStr: Prefer default alias for PCI bus

src/qemu/qemu_capabilities.c                       |  2 +-
src/qemu/qemu_capabilities.h                       |  2 +-
src/qemu/qemu_command.c                            | 45 ++++++++++++++++------
.../qemuxml2argvdata/qemuxml2argv-user-aliases.xml |  4 +-
.../qemuxml2argv-user-aliases2.args                |  1 +
.../qemuxml2argv-user-aliases2.xml                 | 34 ++++++++++++++++
tests/qemuxml2argvtest.c                           |  1 +
7 files changed, 75 insertions(+), 14 deletions(-)
create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-user-aliases2.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-user-aliases2.xml


ACK series

Jan

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]