[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_SPAPR



On Fri, 2017-11-17 at 11:34 +0100, Marc Hartmayer wrote:
> On Wed, Nov 15, 2017 at 12:50 PM +0100, Andrea Bolognani <abologna redhat com> wrote:
> > +        for (i = 0; i < def->nserials; i++) {
> > +            virDomainChrDefPtr serial = def->serials[i];
> > +
> > +            /* Historically, the native console type for some machine types
> > +             * was not set at all, which means it defaulted to ISA even
> > +             * though that was not even remotely accurate. To ensure migration
> > +             * towards older libvirt versions works for such guests, we switch
> > +             * it back to the default here */
> > +            if (flags & VIR_DOMAIN_XML_MIGRATABLE) {
> 
>                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>                This condition is unneeded here as we already checked
>                this ~100 lines before.

Excellent point, thanks for spotting that :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]