[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [jenkins-ci PATCH 3/5] jobs: Rename {check_env} to {env}



On Mon, 2017-11-20 at 14:29 +0100, Pavel Hrdina wrote:
> On Fri, Nov 17, 2017 at 07:26:10PM +0100, Andrea Bolognani wrote:
> > There's no reason to have an environment which is tied, at least
> > in name, to *-check-job only: having a local environment is
> > something that can be useful for any kind of job, so it's better
> > to use a neutral name.
> 
> My proposal was "job_env" and you as a reply suggested "local_env".
> I would probably prefer using "local_env" over "env" since it is
> local environment as you've described it in commit message :).

'env' looks more natural when defining projects, but 'local_env'
mirrors 'global_env' nicely and it's way more greppable, so I've
changed it and pushed :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]