[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/12] qemu: command: Format frontend props with -device rather than -drive



On Mon, Nov 20, 2017 at 18:25:19 +0100, Peter Krempa wrote:
> Historically we've formatted a lot of the attributes of a disk (disk
> geometry, etc) with -drive. Since we use -device now, they should be
> formatted there.
> ---
>  src/qemu/qemu_command.c                                | 5 ++++-
>  tests/qemuxml2argvdata/qemuxml2argv-disk-geometry.args | 6 +++---
>  2 files changed, 7 insertions(+), 4 deletions(-)

So, SNACK to this. Qemu moved the parameters at some time but this does
not do any capability checking so it may have broken older qemus.

I'll strip this patch and the fallout from this series and just send the
refactors. Later on I'll conditionally enable this when we start using
-blockdev and thus these would be lost.

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]