[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [REPOST PATCH v6 5/8] qemu: Get capabilities to use iscsi password-secret argument



On Wed, Nov 08, 2017 at 08:15:58 -0500, John Ferlan wrote:
> Add the capability to use the blockdev-add query-qmp-schema option

This does not make much sense. The capability is detected via
query-qmp-schema in blockdev-add's arguments.

> to find the 'password-secret' parameter that will allow the iSCSI
> code to use the master secret object to encrypt the secret for an
> and only need to provide the object id of the secret on the command
> line thus obsfuscating the passphrase.

You'll have conflicts with recent additions in this patch byt they
should be trivial to solve.

ACK if you fix the commit mesage

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]