[libvirt] [PATCH 3/3] tools: Enable warnings for more binaries/libs

[Michal Privoznik]

On 11/23/2017 03:10 PM, Peter Krempa wrote:
> On Mon, Nov 20, 2017 at 17:36:54 +0100, Erik Skultety wrote:
>> On Thu, Nov 16, 2017 at 02:49:29PM +0100, Michal Privoznik wrote:
>>> Because WARN_CFLAGS and COVERAGE_CFLAGS are not set globally, we
>>> rely on each binary built to include WARN_CFLAGS/COVERAGE_CFLAGS.
>>> But it is easy to forget those - e.g. libvirt_shell.la. However,
>>> don't enable WARN_FLAGS (i.e. don't include AM_CFLAGS) for
>>> wireshark plugin - parts of that code are generated and trigger
>>> some warnings.
>>>
>>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>>> ---
>>>  tools/Makefile.am | 17 +++++++++--------
>>>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> This commit broke build on OSX [1] since apparently readline has
> different definition for some internal variables:
> 
> vsh.c:2903:22: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> 
>     rl_readline_name = ctl->name;
> 
>                      ^ ~~~~~~~~~
> 
> vsh.c:2908:36: error: assigning to 'char *' from 'const char [16]' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> 
>     rl_basic_word_break_characters = " \t\n\\`@$><=;|&{(";
> 
>                                    ^ ~~~~~~~~~~~~~~~~~~~~
> 
> 2 errors generated.
> 
> https://travis-ci.org/libvirt/libvirt/jobs/305251968
> 

Right. I've seen these and quite frankly decided to ignore them. Do we
want to work around old/broken libraries? Where do we write the line?

Michal