[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 17/21] conf: Add target type and model for pl011



On Tue, Nov 21, 2017 at 05:42:27PM +0100, Andrea Bolognani wrote:
> We can finally introduce a specific target model for the pl011 device
> used by mach-virt guests, which means isa-serial will no longer show
> up to confuse users.
> 
> We make sure migration works in both directions by interpreting the
> isa-serial target type, or the lack of target type, appropriately
> when parsing the guest XML, and skipping the newly-introduced type
> when formatting if for migration. We also verify that pl011 is not
> used for non-mach-virt guests and add a bunch of test cases.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=151292
 
I'm not sure that 'system' is a good name for serial type for mach-virt,
it kind of feels like too generic name.  Can we use the "apb-serial" for
mach-virt?  I understand that the "apb" name might not be well known but
at least people that work closely with ARM machines have a chance to
understand it better than "system" name.  Either way, we should document
it better than just listing it as a valid value for type, at least
mention that it's valid for ARM/mach-virt machine and that it's a system
bus or something like that.  The standalone "system" doesn't make it
clear what it actually is.

Otherwise the patch looks good.

Pavel

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]