[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 18/21] conf: add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_SCLP



On Tue, Nov 21, 2017 at 05:42:28PM +0100, Andrea Bolognani wrote:
> From: Pino Toscano <ptoscano redhat com>
> 
> Introduce specific a target types with two models for the console
> devices (sclp and sclplm) used in s390 and s390x guests, so isa-serial
> is no more used for them.
> 
> This makes <serial> usable on s390 and s390x guests, with at most only
> a single sclpconsole and one sclplmconsole devices usable in a single
> guest (due to limitations in QEMU, which will enforce already at
> runtime).
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1449265
> 
> Signed-off-by: Pino Toscano <ptoscano redhat com>
> ---
>  docs/formatdomain.html.in                          |  2 +-
>  docs/schemas/domaincommon.rng                      |  3 ++
>  src/conf/domain_conf.c                             |  5 ++++
>  src/conf/domain_conf.h                             |  3 ++
>  src/qemu/qemu_command.c                            | 16 ++++++++++
>  src/qemu/qemu_domain.c                             | 30 +++++++++++++++++++
>  src/qemu/qemu_domain_address.c                     |  1 +
>  .../qemuxml2argv-s390-serial-2.args                | 24 +++++++++++++++
>  .../qemuxml2argv-s390-serial-2.xml                 | 19 ++++++++++++
>  .../qemuxml2argv-s390-serial-console.args          | 25 ++++++++++++++++
>  .../qemuxml2argv-s390-serial-console.xml           | 15 ++++++++++
>  .../qemuxml2argvdata/qemuxml2argv-s390-serial.args | 22 ++++++++++++++
>  .../qemuxml2argvdata/qemuxml2argv-s390-serial.xml  | 14 +++++++++
>  tests/qemuxml2argvtest.c                           | 16 ++++++++++
>  .../qemuxml2xmlout-s390-serial-2.xml               | 33 +++++++++++++++++++++
>  .../qemuxml2xmlout-s390-serial-console.xml         | 34 ++++++++++++++++++++++
>  .../qemuxml2xmlout-s390-serial.xml                 | 28 ++++++++++++++++++
>  tests/qemuxml2xmltest.c                            |  6 ++++
>  18 files changed, 295 insertions(+), 1 deletion(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-serial-2.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-serial-2.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-serial-console.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-serial-console.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-serial.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-s390-serial.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-s390-serial-2.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-s390-serial-console.xml
>  create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-s390-serial.xml

Reviewed-by: Pavel Hrdina <phrdina redhat com>

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]