[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/2] tests: changing network interface types when backend tag is defined.



Hi Jan and guys,

I was facing a weird issue when I was rewriting this.
If I start with the <source/> tag, the test fails.
I need to start with <mac address/> tag to work properly.

Test fails:
...
    <interface type='network'>
      <source network='default'/>
      <mac address='52:54:00:e5:48:58'/>
...

Test returns ok:
...
    <interface type='network'>
      <mac address='52:54:00:e5:48:58'/>
      <source network='default'/>
...

In my point of view, both structure means the same thing.
It is happening because virDomainNetDefFormat() generates <mac address/> right
after <interface/> tag.

Em 23 de nov de 2017 2:48 PM, "Ján Tomko" <jtomko redhat com> escreveu:
On Fri, Nov 17, 2017 at 07:27:40PM -0200, Julio Faracco wrote:
Some test cases have the backend tag inside wrong interfaces. The backend xml
tag does not support <interface type='user|direct|hostdev'>. So this commit
changes some network types inside the interfaces that have backend defined.

Signed-off-by: Julio Faracco <jcfaracco gmail com>
---
tests/qemuxml2argvdata/qemuxml2argv-tap-vhost-incorrect.xml     | 6 ++++--
tests/qemuxml2argvdata/qemuxml2argv-tap-vhost.xml               | 3 ++-
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml | 6 ++++--
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost.xml           | 3 ++-
4 files changed, 12 insertions(+), 6 deletions(-)


ACK and pushed.

Jan

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]