[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] storage: Fix broken storage_driver build



Commit id '5d5c732d7' had an incorrect assignment and was found
by travis build:

storage/storage_driver.c:1668:14: error: equality comparison with extraneous
      parentheses [-Werror,-Wparentheses-equality]
    if ((obj == virStoragePoolObjListSearch(&driver->pools,

         ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: John Ferlan <jferlan redhat com>
---

 <sigh> Where are those damn pink ears.

 Pushed as a build breaker.

 src/storage/storage_driver.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index cb45052ef7..561ca36f90 100644
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1665,9 +1665,9 @@ storagePoolLookupByTargetPath(virConnectPtr conn,
         return NULL;
 
     storageDriverLock();
-    if ((obj == virStoragePoolObjListSearch(&driver->pools,
-                                            storagePoolLookupByTargetPathCallback,
-                                            path))) {
+    if ((obj = virStoragePoolObjListSearch(&driver->pools,
+                                           storagePoolLookupByTargetPathCallback,
+                                           path))) {
         def = virStoragePoolObjGetDef(obj);
         pool = virGetStoragePool(conn, def->name, def->uuid, NULL, NULL);
         virStoragePoolObjEndAPI(&obj);
-- 
2.13.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]