[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Fix broken storage_driver build



On 11/24/2017 03:45 PM, John Ferlan wrote:
> Commit id '5d5c732d7' had an incorrect assignment and was found
> by travis build:
> 
> storage/storage_driver.c:1668:14: error: equality comparison with extraneous
>       parentheses [-Werror,-Wparentheses-equality]
>     if ((obj == virStoragePoolObjListSearch(&driver->pools,
> 
>          ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
> 

<friday>

>  <sigh> Where are those damn pink ears.

There's a git hook script that takes a picture with webcam on every git
commit [1]. We can set it up and be required to take a selfie when
committing fixes like this :-)

1: https://lolcommits.github.io/

</friday>

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]