[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: fixing virsh prompt when connection changes to readonly mode.



On Mon, Nov 27, 2017 at 10:20:02AM +0100, Erik Skultety wrote:
> On Sun, Nov 26, 2017 at 10:18:11PM -0200, Julio Faracco wrote:
> > This commit, fixes the virsh prompt when reconnection to the same URI is
> > called: `virsh # connect --readonly` (Reconnect). The problem is happening
> > because the code is considering URI (name) as a mandatory parameter to change
> > the prompt. This commit remove the assignment into `priv->readonly` from
> > `if (name)` conditional.
> >
> > Before:
> >     virsh # uri
> >     qemu:///system
> >
> >     virsh # connect --readonly
> >
> >     virsh #
> >
> > After:
> >     virsh # uri
> >     qemu:///system
> >
> >     virsh # connect --readonly
> >
> >     virsh >
> >
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1507737
> >
> > Signed-off-by: Julio Faracco <jcfaracco gmail com>
> 
> Reviewed-by: Erik Skultety <eskultet redhat com>
> Wrapped the commit message to 80 characters and pushed.

Best practices for commit message is to wrap it to 72 characters :).

Pavel

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]