[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 27/30] qemu: Limit isa-serial usage to x86 guests



On Tue, Nov 28, 2017 at 12:48:10PM +0100, Andrea Bolognani wrote:
> The ISA bus is x86 specific, so we should limit usage of isa-serial
> to x86 guests only, just like we already do eg. with sclpconsole and
> s390x guests.

This patch is not necessary, it's actually dead code because in
qemuDomainChrDefPostParse() we set the target type to "none" if
the parsed XML has target type set to "isa-serial" and then we
set the type based on the architecture.

So this patch can be dropped.

Pavel

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]