[libvirt] [PATCH] Remove non-existant 'wiremode' attribute

[Jim Fehlig]

On 11/29/2017 11:01 AM, Daniel P. Berrange wrote:
> The 'wiremode' attribute exists in a couple of Xen XML files, but no code has
> ever parsed that value. It was later added to the RNG schema too, again despite
> there not being any code which parses it.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>   docs/schemas/domaincommon.rng                     | 3 ---
>   tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml | 2 +-
>   tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.xml   | 2 +-
>   3 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 4f739abfb2..1e936f03d3 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -3686,9 +3686,6 @@
>           <optional>
>             <attribute name="service"/>
>           </optional>
> -        <optional>
> -          <attribute name="wiremode"/>
> -        </optional>
>           <optional>
>             <attribute name="channel"/>
>           </optional>
> diff --git a/tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml b/tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml
> index 667ecbd4c2..3f0176e768 100644
> --- a/tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml
> +++ b/tests/xml2sexprdata/xml2sexpr-fv-parallel-tcp.xml
> @@ -32,7 +32,7 @@
>         <target dev='ioemu:hda'/>
>       </disk>
>       <parallel type='tcp'>
> -      <source mode='connect' host='localhost' service='9999' wiremode='raw'/>
> +      <source mode='connect' host='localhost' service='9999'/>
>         <target port='0'/>
>       </parallel>
>       <graphics type='vnc' port='5917' keymap='ja'/>
> diff --git a/tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.xml b/tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.xml
> index 72915b0a39..69603fea3a 100644
> --- a/tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.xml
> +++ b/tests/xml2sexprdata/xml2sexpr-fv-serial-tcp.xml
> @@ -32,7 +32,7 @@
>         <target dev='ioemu:hda'/>
>       </disk>
>       <serial type='tcp'>
> -      <source mode='bind' host='localhost' service='9999' wiremode='raw'/>
> +      <source mode='bind' host='localhost' service='9999'/>
>         <target port='0'/>
>       </serial>
>       <graphics type='vnc' port='5917' keymap='ja'/>
> 

Wow, old cruft. How did you stumble across these?

Reviewed-by: Jim Fehlig <jfehlig at suse.com>

Regards,
Jim