[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] qemu: process: Move handling of non-backing files into qemuDomainDetermineDiskChain




On 11/24/2017 07:21 AM, Peter Krempa wrote:
> Until now we would skip loading of the backing chain for files which
> don't support backing chains only when starting up the VM. Move the
> check from qemuProcessPrepareHostStorage with some adaptations so that's
> always applied.
> ---
>  src/qemu/qemu_domain.c  | 17 +++++++++++++++++
>  src/qemu/qemu_process.c | 10 ----------
>  2 files changed, 17 insertions(+), 10 deletions(-)
> 

Does it matter or should the check go before the
virStorageSourceBackingStoreClear... Up through this point we did it
before anyway.

Reviewed-by: John Ferlan <jferlan redhat com>

(for the code regardless of your decision on placement)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]