[libvirt] [PATCH] tests: Do not ignore mode parameter in mocked open()

Martin Kletzander mkletzan at redhat.com
Tue Oct 3 14:06:39 UTC 2017

On Tue, Oct 03, 2017 at 02:07:18PM +0200, Jiri Denemark wrote:
>From: Luyao Huang <lhuang at redhat.com>
>This is normally not an issue since the tests which use mocked open() do
>not create files. But once coverage build is enabled, gcov_open will use
>O_CREATE and real_open will read random data rather than the actual mode
>Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> tests/virfilewrapper.c | 13 ++++++++++++-
> tests/virusbmock.c     | 15 ++++++++++++++-
> 2 files changed, 26 insertions(+), 2 deletions(-)

ACK, I guess you don't need this in the release, do you?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171003/67af229b/attachment-0001.sig>

More information about the libvir-list mailing list