[libvirt] [PATCH 3/3] virDomainNetFindIdx: Ignore auto generated MAC addresses

Erik Skultety eskultet at redhat.com
Wed Oct 4 15:03:39 UTC 2017

> I don't think this is right. Consider the following scenario. There are
> two interfaces in a domain with $mac1, $pci1 and $mac2, $pci2. What
> happens if user passes $mac1+$pci2 or vice versa? With my code, we error
> out. With this suggestion we match device based on PCI address (even

Fair point, I haven't considered this scenario, as I couldn't imagine someone
hitting this corner case. Nevertheless, doesn't matter, mine assumption was
wrong, thank you for pointing it out.


More information about the libvir-list mailing list