[libvirt] [PATCH 3/7] qemu: process: Pass flags to qemuProcessPrepareHost

[John Ferlan]

On 10/04/2017 07:42 AM, Peter Krempa wrote:
> Pass flags to the function rather than just whether we have incoming
> migration. This also enforces correct startup policy for USB devices
> when reverting from a snapshot.
> ---
>  src/qemu/qemu_migration.c | 2 +-
>  src/qemu/qemu_process.c   | 8 ++++----
>  src/qemu/qemu_process.h   | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 078da1dfd..dd60071bf 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -2687,7 +2687,7 @@ qemuMigrationPrepareAny(virQEMUDriverPtr driver,
>      if (qemuProcessPrepareDomain(dconn, driver, vm, startFlags) < 0)
>          goto stopjob;
> 
> -    if (qemuProcessPrepareHost(driver, vm, !!incoming) < 0)
> +    if (qemuProcessPrepareHost(driver, vm, startFlags) < 0)

yah! - removing an essentially useless !!incoming since it couldn't be
anything but true...

Reviewed-by: John Ferlan <jferlan at redhat.com>

John

[...]