[libvirt] [PATCH] build: exclude more files from all the syntax checks

Eric Blake eblake at redhat.com
Fri Oct 6 14:58:54 UTC 2017

On 10/06/2017 08:23 AM, Michal Privoznik wrote:

>>> .spec is not in the repo, so it's never checked. And then, we perhaps
>>> want to check .spec.in? For instance for space at EOF.
>> .spec is generated from .spec.in, so for a builddir==srcdir build,
>> syntax-check will find both; hence, IMHO both ought to be either
>> skipped or checked, but together.
> Is that right? I always thought that syntax-check runs only over the
> files that are in the git and not generated ones:

Many checks run only on checked-in files, but some checks also run on
in-tree files.  It depends whether the check was written with
in_vc_files, in_files, or something else.

In fact, many builtin rules in maint.mk use:


to limit to C-like files; I think part of the problem is that there are
syntax-check rules that forget to use this limiting filter, and end up
getting applied to too many files.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171006/72012f53/attachment-0001.sig>

More information about the libvir-list mailing list