[libvirt] [PATCH] qemu: Floppy disks not supported on pSeries machines

Ján Tomko jtomko at redhat.com
Tue Oct 10 08:35:43 UTC 2017


On Sun, Oct 08, 2017 at 03:26:13PM +0530, Kothapally Madhu Pavan wrote:
>Signed-off-by: Kothapally Madhu Pavan <kmp at linux.vnet.ibm.com>
>---
> src/qemu/qemu_parse_command.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/src/qemu/qemu_parse_command.c b/src/qemu/qemu_parse_command.c
>index 7c409b0..d5745ce 100644
>--- a/src/qemu/qemu_parse_command.c
>+++ b/src/qemu/qemu_parse_command.c
>@@ -760,6 +760,11 @@ qemuParseCommandLineDisk(virDomainXMLOptionPtr xmlopt,
>             } else if (STREQ(values[i], "floppy")) {
>                 def->bus = VIR_DOMAIN_DISK_BUS_FDC;
>                 def->device = VIR_DOMAIN_DISK_DEVICE_FLOPPY;
>+                if (qemuDomainIsPSeries(dom)) {
>+                    virReportError(VIR_ERR_INTERNAL_ERROR,
>+                                   _("pseries systems do not support floppy devices '%s'"), val);
>+                    goto error;

Do we actually need to worry about that here?

I would expect that if pseries does not support floppy devices, you will
not be able to run QEMU with such command line in the first place.

So this case would never happen with QEMU that is actually running.

Jan

>+                }
>             } else if (STREQ(values[i], "virtio")) {
>                 def->bus = VIR_DOMAIN_DISK_BUS_VIRTIO;
>             } else if (STREQ(values[i], "xen")) {
>-- 
>1.8.3.1
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171010/f578bc8c/attachment-0001.sig>


More information about the libvir-list mailing list