[libvirt] [PATCH 5/9] util: storagefile: Tolerate NULL path when looking up volume in chain

[Eric Blake]

On 10/12/2017 02:07 PM, Peter Krempa wrote:
> chain->path may be NULL e.g. for NDB drives, so the check needs to avoid

s/NDB/NBD/ ?

> dereferencing the path in such case
> ---
>  src/util/virstoragefile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake at redhat.com>

> 
> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
> index 9568a5068..818a679de 100644
> --- a/src/util/virstoragefile.c
> +++ b/src/util/virstoragefile.c
> @@ -1610,7 +1610,7 @@ virStorageFileChainLookup(virStorageSourcePtr chain,
>                  break;
>          } else {
>              if (STREQ_NULLABLE(name, chain->relPath) ||
> -                STREQ(name, chain->path))
> +                STREQ_NULLABLE(name, chain->path))
>                  break;
> 
>              if (nameIsFile && virStorageSourceIsLocalStorage(chain)) {
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171012/2d1b378d/attachment-0001.sig>