[libvirt] [PATCH] qemu: change monitor.sock from /var/lib/libvirt/qemu/domain-*** to /var/run/libvirt/qemu/domain-***

[Daniel P. Berrange]

On Fri, Oct 13, 2017 at 09:21:45AM +0200, Martin Kletzander wrote:
> On Fri, Oct 13, 2017 at 11:36:52AM +0800, xinhua.Cao wrote:
> > directory /var/lib alway is Persistence directory, but in redhat system, /var/run is memory directory.
> > our running domain xml is saved at /var/run/libvirt/qemu. so if we cold reset system,
> > the /var/run/libvirt/qemu directory is clear, but /var/lib/libvirt/qemu/domain-*** is saved. so there
> > have same /var/run/libvirt/qemu/domain-*** directory will be left over at system cold reset.
> 
> Is that he only problem?  I know it sounds right to have that in a
> runtime directory, but for me it would also make sense to have that in a
> persistent directory.  Either this or any other file that suggests we
> did not clean up a domain yet.  I'm not sure we are currently doing it
> or that it's a reason for why libDir was chosen, but it might have been.

libDir is almost certainly just a historical accident. Conceptually runDir
makes more sense since this requires no storage across reboots.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|