[libvirt] [PATCH 4/4] qemu: Fix CPU model broken by older libvirt

Jiri Denemark jdenemar at redhat.com
Tue Oct 17 13:27:21 UTC 2017


On Tue, Oct 17, 2017 at 14:34:25 +0200, Pavel Hrdina wrote:
> On Wed, Oct 11, 2017 at 12:11:17PM +0200, Jiri Denemark wrote:
> > When libvirt older than 3.9.0 reconnected to a running domain started by
> > old libvirt it could have messed up the expansion of host-model by
> > adding features QEMU does not support (such as cmt). Thus whenever we
> > reconnect to a running domain, revert to an active snapshot, or restore
> > a saved domain we need to check the guest CPU model and remove the
> > CPU features unknown to QEMU. We can do this because we know the domain
> > was successfully started, which means the CPU did not contain the
> > features when libvirt started the domain.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=1495171
> > 
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> >  src/qemu/qemu_domain.c  | 76 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  src/qemu/qemu_domain.h  |  4 +++
> >  src/qemu/qemu_driver.c  | 14 +++++++++
> >  src/qemu/qemu_process.c |  9 ++++++
> >  4 files changed, 103 insertions(+)
> 
> Reviewed-by: Pavel Hrdina <phrdina at redhat.com>

Thanks for the review. I fixed the issues and pushed this series.

Jirka




More information about the libvir-list mailing list