[libvirt] [PATCH 0/6] qemu: hotplug: Kill duplicated code in disk hotplug (blockdev-add saga)

[Ján Tomko]

On Thu, Oct 19, 2017 at 03:16:32PM +0200, Peter Krempa wrote:
>A lot of code was copypasted into the three disk attaching functions
>which are (almost) identical (one was forgotten), without refactoring it
>first. Let's reduce two copies of the ugly code. BTW this adds support
>for disk encryption and storage source authentication for USB disks.
>
>Peter Krempa (6):
>  qemu: address: Remove dead code when un-reserving PCI address
>  qemu: hotplug: Remove wrong check for empty disks
>  qemu: hotplug: Use disk target in debug/warning messages where
>    appropriate
>  qemu: hotplug: extract disk hotplug worker code
>  qemu: hotplug: Reuse qemuDomainAttachDiskGeneric in
>    qemuDomainAttachSCSIDisk
>  qemu: hotplug: Reuse qemuDomainAttachDiskGeneric in
>    qemuDomainAttachUSBMassStorageDevice
>
> src/conf/domain_addr.c         |   3 +-
> src/conf/domain_addr.h         |   4 +-
> src/qemu/qemu_domain_address.c |   7 +-
> src/qemu/qemu_hotplug.c        | 273 ++++++++---------------------------------
> 4 files changed, 53 insertions(+), 234 deletions(-)

ACK series

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171019/e6887b37/attachment-0001.sig>