[libvirt] [jenkins-ci PATCH 4/5] jobs: Define $OSINFO_SYSTEM_DIR in default make_env
Andrea Bolognani
abologna at redhat.com
Fri Oct 27 11:16:19 UTC 2017
On Fri, 2017-10-27 at 09:20 +0100, Daniel P. Berrange wrote:
> > title: libosinfo
> > - make_env: |
> > - MAKE='make'
> > - unamestr=`uname`
> > - if [ "$unamestr" = 'FreeBSD' ]; then
> > - MAKE='gmake'
> > - fi
> > - export OSINFO_SYSTEM_DIR=$VIRT_PREFIX/share/osinfo
> > jobs:
> > - autotools-build-job:
> > parent_jobs: 'osinfo-db-master-build'
>
> Again, I don't really think this change is a benefit. Project specific env
> vars should only be defined against the project rules.
>
> If we want to eliminate the duplication, of the make variables, we should
> change the variables we set. ie, stop overriding 'make_env' here, and instead
> provide a general 'build_env' property that projects can set, that gets subs
> into the autotools.yaml file.
Okay, I can do that. I'll post a v2 shortly.
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list