[libvirt] [PATCH 1/7] qemu: process: document parameters for startup preparing functions

John Ferlan jferlan at redhat.com
Wed Oct 4 15:56:38 UTC 2017



On 10/04/2017 07:42 AM, Peter Krempa wrote:
> Document mainly what flag values are passed in.
> ---
>  src/qemu/qemu_process.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index bde3ba462..7f0ef2664 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -5276,7 +5276,11 @@ qemuProcessPrepareDomainNUMAPlacement(virDomainObjPtr vm,
> 
> 
>  /**
> - * qemuProcessPrepareDomain
> + * qemuProcessPrepareDomain:
> + * @conn: connection object (for looking up storage volumes)
> + * @driver: qemu driver
> + * @vm: domain object
> + * @flags: qemuProcessStartFlags
>   *
>   * This function groups all code that modifies only live XML of a domain which
>   * is about to start and it's the only place to do those modifications.
> @@ -5404,7 +5408,10 @@ qemuProcessPrepareDomain(virConnectPtr conn,
> 
> 
>  /**
> - * qemuProcessPrepareHost
> + * qemuProcessPrepareHost:
> + * @driver: qemu driver
> + * @vm: domain object
> + * @incoming: true if we are preparing an incomming migration

s/incomming/incoming

Reviewed-by: John Ferlan <jferlan at redhat.com>

John

>   *
>   * This function groups all code that modifies host system (which also may
>   * update live XML) to prepare environment for a domain which is about to start
> 




More information about the libvir-list mailing list