[libvirt] [PATCH 2/2] qemu: clarify error message for index 0 PIIX3 USB controller

[John Ferlan]

On 09/26/2017 07:05 AM, Ján Tomko wrote:
> The address is restricted to 0:0:1.2 only for the piix3-uhci controller
> with index 0.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1460602
> ---
>  src/qemu/qemu_domain_address.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
> index f35e01e5a..17ef93a3b 100644
> --- a/src/qemu/qemu_domain_address.c
> +++ b/src/qemu/qemu_domain_address.c
> @@ -1419,7 +1419,7 @@ qemuDomainValidateDevicePCISlotsPIIX3(virDomainDefPtr def,
>                      cont->info.addr.pci.slot != 1 ||
>                      cont->info.addr.pci.function != 2) {
>                      virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> -                                   _("PIIX3 USB controller must have PCI address 0:0:1.2"));
> +                                   _("PIIX3 USB controller with index 0 must have PCI address 0:0:1.2"));

Consider:

PIIX3 USB controller using index 0 must use PCI address 0:0:1.2"

or

PIIX3 USB controller at index 0 must use PCI address 0:0:1.2"

?

>                      goto cleanup;
>                  }
>              } else {
> 

Reviewed-by: John Ferlan <jferlan at redhat.com>

John