[libvirt] [PATCH 3/3] nodedev: Introduce virNodeDeviceObjListForEachCb

Erik Skultety eskultet at redhat.com
Thu Oct 12 13:46:25 UTC 2017


On Tue, Oct 10, 2017 at 09:54:28AM -0400, John Ferlan wrote:
> Rather than separate functions for NumOfDevices, GetNames, and
> ListExport - let's converge the code into one handler.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---

NACK, for the very same reasons stated in [1], IOW we really should not make
this a busybox. But unlike [1], I'm not entirely sure what a nice cleanup would
look like (and it sure needs some).

Erik




More information about the libvir-list mailing list