[libvirt] [PATCH 4/9] util: storage: use stored index to lookup disks

Eric Blake eblake at redhat.com
Thu Oct 12 20:03:10 UTC 2017


On 10/12/2017 02:07 PM, Peter Krempa wrote:
> We can now use the backing store ID directly rather than counting the
> number of images seen while looking up images.
> ---
>  src/util/virstoragefile.c | 18 +++---------------
>  1 file changed, 3 insertions(+), 15 deletions(-)
> 

I guess if we've always been counting the chain depth, the id
renumbering question I had on patch 3 is somewhat answered: 'vda[1]'
does not always refer to the same file in the chain.  As long as we're
okay with that, I didn't see any other problems in patch 3 or in this one.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20171012/df77c34a/attachment-0001.sig>


More information about the libvir-list mailing list