[libvirt] [PATCH 11/23] cputest: Avoid calling json_reformat in cpu-parse.sh
jdenemar at redhat.com
Fri Oct 13 17:01:43 UTC 2017
On Thu, Oct 12, 2017 at 16:18:20 -0400, John Ferlan wrote:
> On 10/04/2017 10:58 AM, Jiri Denemark wrote:
> > Various version of json_reformat use different number of spaces for
> > indenting. Let's use a simple python reformatter to gain full control
> > over the formatting for consistent results.
> > Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> > ---
> > tests/cputestdata/cpu-parse.sh | 2 +-
> > tests/cputestdata/cpu-reformat.py | 9 +++++++++
> > 2 files changed, 10 insertions(+), 1 deletion(-)
> > create mode 100755 tests/cputestdata/cpu-reformat.py
> Looks reasonable - python, formatting, and scripting - not exactly in my
> wheel house. Still doesn't 'tr -s '\n' just replace multiple occurrences
> of \n with just one? I suppose that's being done along with some amount
> of space adding.
json_reformat formats empty arrays as
which breaks our test monitor. The python formatting code doesn't do
that so we don't need "tr -s '\n'" anymore.
More information about the libvir-list