[libvirt] [PATCH go-xml] let disk source omitempty for ejecting cdrom/floppy
Daniel P. Berrange
berrange at redhat.com
Mon Oct 16 09:55:04 UTC 2017
On Mon, Oct 16, 2017 at 05:36:54PM +0800, zhenwei.pi wrote:
> Signed-off-by: zhenwei.pi <zhenwei.pi at youruncloud.com>
> ---
> domain.go | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/domain.go b/domain.go
> index bacab11..f9d567d 100644
> --- a/domain.go
> +++ b/domain.go
> @@ -117,7 +117,7 @@ type DomainDisk struct {
> Snapshot string `xml:"snapshot,attr,omitempty"`
> Driver *DomainDiskDriver `xml:"driver"`
> Auth *DomainDiskAuth `xml:"auth"`
> - Source *DomainDiskSource `xml:"source"`
> + Source *DomainDiskSource `xml:"source,omitempty"`
> Target *DomainDiskTarget `xml:"target"`
> IOTune *DomainDiskIOTune `xml:"iotune"`
> Serial string `xml:"serial,omitempty"`
AFAIK, this should not be needed - the Source element is already
a pointer, so if you leave the pointer as nil it should omit
the <source> element entirely
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list